[2.3.1] Wishlist module shouldn't have a hard dependency on Captcha module

[hostep]

Preconditions (*)

1. Magento 2.3.1
2. PHP 7.2.15

Steps to reproduce (*)

1. Install Magento 2.3.1 using composer
2. Look at the file vendor/magento/module-wishlist/composer.json

Expected result (*)

1. Not seeing magento/module-captcha in there
2. The Wishlist module should be able to work when the captcha module isn't installed

Actual result (*)

1. Seeing magento/module-captcha in there
2. Not sure the wishlist module works without captcha installed, not tested yet.

Discussion

This dependency got introduced in Magento 2.3.1 in d8eacad#diff-649e244f0c6d1bd88471ebeee385eb6e

We don't want this hard dependency, because we don't want to install the default Captcha module of Magento, we have our own module for that and we don't need two modules providing similar functionality.

Until now, it looks like only the sendfriend module had a hard dependency on the captcha module (this is probably incorrect as well). We don't need the sendfriend module either, so we also don't install that, which allowed us to remove the captcha module as well.
But we do need the wishlist module so we can no longer remove the captcha module.

I'm not sure if this hard dependency can be removed somehow, it probably won't be that easy?
Maybe the coupling between captcha & wishlist should have been done in a new module instead of adding it to the existing wishlist module?

[m2-assistant]

Hi @hostep. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@hostep do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[orlangur]

Totally agree on that, it could have been easily implemented as a plugin/interceptor in a separate module. Especially such unreasonable dependencies should not be introduced in patch releases. Generally amount of hard dependencies must decrease, not increase.

[m2-assistant]

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99067, MAGETWO-99068 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.