2.3 only - creating attribute option value using API returns unexpected response

[hostep]

Preconditions

1. Tested with 2.4-develop branch
2. PHP 7.1.22 & 7.2

Steps to reproduce

1. Setup a clean Magento installation
2. Create an Integration with full access rights & activate it, I'm assuming the access token is abcd (see step 4)
3. Using the adminhtml, create a new dropdown product attribute, use attribute code: dropdown
4. Add an option through a REST call (make sure to use an option which doesn't exist yet):

curl -k -X POST "https://domain.tld/rest/all/V1/products/attributes/dropdown/options" -H "accept: application/json" -H "Content-Type: application/json" -H "Authorization: Bearer abcd" -d "{ \"option\": { \"label\": \"whatever\" }}"

Expected result

1. Return value should be the ID of the new option

Actual result

1. Return value is "id_new_option"
   

Further discussion

This is a follow up on #8810, this issue was supposed to be fixed by #12920
But here's what seemed to have happened:

• The above PR was first returning the full attribute option data with the label and the ID in JSON format.
• But @okorshenko remarked in his review that only the ID should be returned.
• @sidolov then added commit 5eef1d9 which turned the return value (probably accidentally) into: "new_option"
• And then @sidolov added another commit (ac48c86) which now returns: "id_new_option"

This was probably all done by accident, I'm opening this issue so this isn't getting forgotten.

[magento-engcom-team]

Hi @hostep. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@hostep do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[Nazar65]

#mageconf

[magento-engcom-team]

@Nazar65 thank you for joining. Please accept team invitation here and self-assign the issue.

[magento-engcom-team]

Hi @Nazar65. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

@shikhamis11 Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97311 were created