Magento2 Attribute option does not validate for existing records before insert

[zeeshan2523806]

Preconditions

When creating product attribute and their options dynamically magento does not validate the data before inserting it into the database,

1. Magento2.2.3

Steps to reproduce

1. Create a product eav attribute dynamically using class (Magento\Catalog\Model\ResourceModel\Eav\Attribute) and set the entity type Id to the type id of catalog_product (See sample code below) (eg: attribute code = colors)
2. generate a list of possible options and then add those options into that product EAV attribute by using (Magento\Eav\Setup\EavSetup -> AddOption()) (optionarray = 'Black, Blue, White')
3. Generate some more options (pick some of those which are already existed) and add then add them into the product attribute by following the same step describe in step 2. ('White, Green, Purple')

Expected result

1. Magento should validate the option Array and check if any of the item already exist or not, If it exist then it should not insert that (Possible options need to be in the attribute code should be 'Black, Blue, White, Green, Purple')

Actual result

1. Magento create duplicate option for the same store even the option already exists. Data in the current option array are ( 'Black, Blue, White, White, Green, Purple')) check the repetative entry for the option value 'White.'

here are the sample code:

For step 1:

Inject the EaV Attribute Factory in your constructor and perform this action

$attributeData = [
                    'attribute_code' => $code,
                    'is_global' => 1,
                    'frontend_label' => $code,
                    'frontend_input' => 'select',
                    'default_value_text' => '',
                    'default_value_yesno' => 0,
                    'default_value_date' => '',
                    'default_value_textarea' => '',
                    'is_unique' => 0,
                    'apply_to' => 0,
                    'is_required' => 0,
                    'is_configurable' => 1,
                    'is_searchable' => 1,
                    'is_comparable' => 1,
                    'is_user_defined' => 1,
                    'is_visible_in_advanced_search' => 1,
                    'is_used_for_price_rules' => 0,
                    'is_wysiwyg_enabled' => 0,
                    'is_html_allowed_on_front' => 1,
                    'is_visible_on_front' => 0,
                    'used_in_product_listing' => 0,
                    'used_for_sort_by' => 1,
                    'is_filterable' => 1,
                    'is_filterable_in_search' => 1,
                    'backend_type' => 'varchar'
                ];
/*** Magento\Catalog\Model\ResourceModel\Eav\AttributeFactory  */ 
                $this->_eavAttributeFactory->create()
                    ->addData($attributeData)
                    ->setEntityTypeId($this->getEntityTypeId('catalog_product'))
                    ->save();

Step 2:

        $attribute_code = 'COLOURS';
        $options        =   array('Black', 'Green');

  /*** Magento\Eav\Setup\EavSetup  */
        $this->eavSetupFactory->create()
            ->addAttributeOption(
                [
                    'values' => $options,
                    'attribute_id' => $this->getAttributeIdbyCode($attribute_code) := '4'
                ]
            );

Step 3:

        $attribute_code = 'COLOURS';
        $options        =   array('Black', 'White');

  /*** Magento\Eav\Setup\EavSetup  */
        $this->eavSetupFactory->create()
            ->addAttributeOption(
                [
                    'values' => $options,
                    'attribute_id' => $this->getAttributeIdbyCode($attribute_code) := '4'
                ]
            );

[magento-engcom-team]

Hi @zeeshan2523806. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@zeeshan2523806 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[zeeshan2523806]

its development bug, not sure how i can produce this on the existing setup

[engcom-backlog-nickolas]

Hello @zeeshan2523806, thank you for your report.
We've acknowledged the issue and added to our backlog.

[medmek]

any workaround for the mean time ?
I see that in contrast with 'value' the 'values' doesn't have an $intOptionId by which the replacement could be done easily, so for the mean time I propose to use the sortOrder value.

magento2/app/code/Magento/Eav/Setup/EavSetup.php

Lines 931 to 941 in 24376e9

	} elseif (isset($option['values'])) {
	foreach ($option['values'] as $sortOrder => $label) {
	// add option
	$data = ['attribute_id' => $option['attribute_id'], 'sort_order' => $sortOrder];
	$this->setup->getConnection()->insert($optionTable, $data);
	$intOptionId = $this->setup->getConnection()->lastInsertId($optionTable);
	$data = ['option_id' => $intOptionId, 'store_id' => 0, 'value' => $label];
	$this->setup->getConnection()->insert($optionValueTable, $data);
	}
	}

line 933 :

// add option
$this->setup->getConnection()->delete($optionTable, ['attribute_id =?' =>$option['attribute_id'], 'sort_order =?' => $sortOrder]);
$data = ['attribute_id' => $option['attribute_id'], 'sort_order' => $sortOrder];
...

Haven't had time to test it yet