Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup version optional but required... #1670

Closed
andrew-smart opened this issue Aug 13, 2015 · 3 comments
Closed

setup version optional but required... #1670

andrew-smart opened this issue Aug 13, 2015 · 3 comments
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@andrew-smart
Copy link
Contributor

Hi,

Is there a reason why in the xsd declaration (https://github.com/magento/magento2/blob/develop/lib/internal/Magento/Framework/Module/etc/module.xsd#L46) setup_version is marked as optional but required by this check (https://github.com/magento/magento2/blob/develop/lib/internal/Magento/Framework/Module/Declaration/Converter/Dom.php#L32).

Is this now the equivalent to "version" in Magento 1 and that is why it is required?

Also, despite a module doing very little and not containing any setup scripts you are forced to run bin/magento setup:upgrade i presume as a result of the setup_version. If that is just the way it needs to work then fine we can incorporate it in to our flow.

Thanks,
Andy

@mazhalai
Copy link
Contributor

@andrew-smart Thank you for reporting, we have created MAGETWO-41517 to investigate

@mazhalai mazhalai added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development PS labels Aug 13, 2015
@piotrekkaminski
Copy link
Contributor

This is fixed now and should be already published.

@mazhalai
Copy link
Contributor

mazhalai commented Oct 8, 2015

MAGETWO-41517 was closed in favor of MAGETWO-40320

@daim2k5 daim2k5 closed this as completed Nov 10, 2015
magento-team pushed a commit that referenced this issue Nov 9, 2017
…seNotification

[Arctic Foxes] Advanced Reporting and Release Notification Pull Request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

4 participants