-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Fixed in 2.1.xThe issue has been fixed in 2.1 release lineThe issue has been fixed in 2.1 release lineFixed in 2.2.xThe issue has been fixed in 2.2 release lineThe issue has been fixed in 2.2 release lineFixed in 2.3.xThe issue has been fixed in 2.3 release lineThe issue has been fixed in 2.3 release lineIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passed
Description
Preconditions
Any Magento 2
FE theme inherited from Magento/Blank
Steps to reproduce
In Custom/theme/web/css/source/_theme.less
set less variables to:
@tab-content__border-top-status: false;
@tab-content__border: 1px solid #000;
Expected result
Tabs content has border
Actual result
Tabs content has no border
What causes the issue
web/css/source/_sections.less calls .lib-data-tabs()
mixin with @_tab-content-border-top-status: true
argument, so @tab-content__border-top-status
variable isn't used in .lib-data-tabs()
Solution
- Remove
@_tab-content-border-top-status: true
argument in web/css/source/_sections.less (as it's done in Magento/Luma); - Add
@tab-content__border-top-status: true
in web/css/source/_variables.less
Workaround
Create Custom/theme/web/css/source/_sections_extend.less
with:
.media-width(@extremum, @break) when (@extremum = 'min') and (@break = @screen__m) {
.product.data.items {
> .item.content {
._lib-tab-content-border(
@_tab-content-border-top-status: @tab-content__border-top-status
);
}
}
}
Metadata
Metadata
Assignees
Labels
Fixed in 2.1.xThe issue has been fixed in 2.1 release lineThe issue has been fixed in 2.1 release lineFixed in 2.2.xThe issue has been fixed in 2.2 release lineThe issue has been fixed in 2.2 release lineFixed in 2.3.xThe issue has been fixed in 2.3 release lineThe issue has been fixed in 2.3 release lineIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passed