Skip to content

Fixed Java.lang.IllegalArgumentException During adding a new method… #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Fixed Java.lang.IllegalArgumentException During adding a new method… #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51c78ef
Fixed `Java.lang.IllegalArgumentException` During adding a new method…
Apr 26, 2021
9fd8ec1
Merge branch '3.2.2-develop' of github.com:magento/magento2-phpstorm-…
Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0).
### Fixed

- New entity layout name and edit entity layout name inside it
- `Java.lang.IllegalArgumentException` During adding a new method into an existing plugin

## 3.2.1

Expand Down
8 changes: 7 additions & 1 deletion resources/META-INF/pluginIcon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
22 changes: 15 additions & 7 deletions src/com/magento/idea/magento2plugin/actions/generation/PluginGenerateMethodHandlerBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
import gnu.trove.THashSet;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import java.util.Locale;
Expand Down Expand Up @@ -318,18 +317,27 @@ public static Collection<PhpNamedElementNode> fixOrderToBeAsOriginalFiles(
final PhpNamedElementNode... selected
) {
final List<PhpNamedElementNode> newSelected = ContainerUtil.newArrayList(selected);
Collections.sort(newSelected, (o1, o2) -> {
newSelected.sort((o1, o2) -> {
final PsiElement psiElement = o1.getPsiElement();
final PsiElement psiElement2 = o2.getPsiElement();
final PsiFile containingFile = psiElement.getContainingFile();
final PsiFile containingFile2 = psiElement2.getContainingFile();
return containingFile.equals(containingFile2)
? psiElement.getTextOffset() - psiElement2.getTextOffset()
: containingFile.getName().compareTo(containingFile2.getName());
? psiElement.getTextOffset() - psiElement2.getTextOffset()
: getDocumentPosition(containingFile, containingFile2);
});
return newSelected;
}

private static int getDocumentPosition(
final PsiFile containingFile,
final PsiFile containingFile2
) {
return containingFile.getVirtualFile().getPresentableUrl().compareTo(
containingFile2.getVirtualFile().getPresentableUrl()
);
}

private static int getSuitableEditorPosition(final Editor editor, final PhpFile phpFile) {
final PsiElement currElement = phpFile.findElementAt(editor.getCaretModel().getOffset());
if (currElement != null) {
Expand Down Expand Up @@ -371,9 +379,9 @@ private static boolean isClassMember(final PsiElement element) {
return false;
}
final IElementType elementType = element.getNode().getElementType();
return elementType == PhpElementTypes.CLASS_FIELDS
|| elementType == PhpElementTypes.CLASS_CONSTANTS
|| elementType == PhpStubElementTypes.CLASS_METHOD;
return elementType.equals(PhpElementTypes.CLASS_FIELDS)
|| elementType.equals(PhpElementTypes.CLASS_CONSTANTS)
|| elementType.equals(PhpStubElementTypes.CLASS_METHOD);
}

private static int getNextPos(final PsiElement element) {
Expand Down