-
Notifications
You must be signed in to change notification settings - Fork 105
Refactored php file generators to extend PhpFileGenerator and etc. #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored php file generators to extend PhpFileGenerator and etc. #526
Conversation
…ic test issues, fixed Edit entity controller generation code duplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bohdan-harniuk thank you for these adjustments. Could you please check the following test case?
- Create a new Entity
- Add couple of entity's properties: string, boolean, float
Expected Result
The generated interfaces/models, have the correct selected type.
/**
* Getter for Name.
*
* @return string|null
*/
public function getName(): ?string;
Actual Result
The generated interfaces/models, have the wrong selected type, pointing always to int
type.
/**
* Getter for Name.
*
* @return int|null
*/
public function getName(): ?int;
Hello, @eduard13 |
@bohdan-harniuk, looks like the issue is related to the type field, that doesn't get unfocus state and the selected value isn't saved. Can we make sure the selected values are used on creating the parameters? Beside this one, could you please check the below errors? You can get them, by trying to generate UiComponents for 2 entities within the same module. |
@eduard13 , thank you for your findings!! It looks like critical ones. I will try to fix them in this PR. Thank you a lot. |
…st case for grid list generation
Hello, @eduard13
Please, review my code one more time Thanks you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing those issues 👍
Description (*)
What was done:
Contribution checklist (*)