Skip to content

Added navigation to tab with error on field #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bohdan-harniuk
Copy link
Collaborator

Description (*)
Added navigation to the tab with an error that occurred on a field.

NavigateToTabWithError

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bohdan-harniuk, could you please check the following test case?

  1. Open the M2 Entity dialog
  2. Don't select Create Admin UI Components
  3. Click OK button

As result, you won't be redirected to the first tab that has errors.

2021-03-30 08 49 58

Thank you.

@bohdan-harniuk
Copy link
Collaborator Author

bohdan-harniuk commented Mar 30, 2021

Hi, @eduard13. This case didn't cover intentionally. @anzin reported a bug that fields validated even if they are in the hidden tab. In this case, we cannot navigate to the hidden tab. This will be fixed by @anzin because it has nothing to do with navigation. It is all about validation.

Thank you.

@eduard13 eduard13 added Medium and removed QA failed labels Mar 30, 2021
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then let's fix the validations then 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants