Fixed bug invalid check setup_version #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
VitaliyBoyko
requested changes
Mar 10, 2021
| @@ -27,6 +28,8 @@ | |||
|
|
|||
| public class ModuleDeclarationInModuleXmlInspection extends XmlSuppressableInspectionTool { | |||
|
|
|||
| private static final String MODULE_NAME = "name"; | |||
There was a problem hiding this comment.
add this constant to com.magento.idea.magento2plugin.magento.files.ModuleXml
And write a test for mentioned in the issue case please. Thank you!
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
…plugin into fix-bug-invalid-check-setup-version
|
@VitaliyBoyko I've fixed code by recommendation, and added test. |
VitaliyBoyko
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
I've fixed the bug invalid check 'setup_version'.
Contribution checklist (*)