Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated framework interfaces #735

Closed
wants to merge 2 commits into from
Closed

Remove deprecated framework interfaces #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f23f7b
Using \Magento\Framework\Data\OptionSourceInterface instead of Magent…
vlmed Mar 1, 2021
ece147e
Removed pagebuilder_preview_sid_resolving plugin
vlmed Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/PageBuilder/Model/Config/Source/Country.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*
* @api
*/
class Country implements \Magento\Framework\Option\ArrayInterface
class Country implements \Magento\Framework\Data\OptionSourceInterface
{
/**
* @var \Magento\Directory\Model\ResourceModel\Country\Collection
Expand Down
49 changes: 0 additions & 49 deletions app/code/Magento/PageBuilder/Plugin/Framework/Session/SidResolver.php
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions app/code/Magento/PageBuilder/etc/di.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,6 @@
</argument>
</arguments>
</type>
<type name="Magento\Framework\Session\SidResolver">
<plugin name="pagebuilder_preview_sid_resolving" type="Magento\PageBuilder\Plugin\Framework\Session\SidResolver" />
</type>
<virtualType name="Magento\PageBuilder\Model\Catalog\Sorting\Date\NewestTop" type="Magento\PageBuilder\Model\Catalog\Sorting\SimpleOption">
<arguments>
<argument name="label" xsi:type="string">Newest products first</argument>
Expand Down