Skip to content

Conversation

@davemacaulay
Copy link
Contributor

@davemacaulay davemacaulay commented Nov 7, 2019

Scope

Bug

  • PB-76 PageBuilder Product List Template Is Missing Product Color & Size Options in Admin
  • PB-225 Page builder JS and CSS files are not loading and going to 404

Builds

See: https://github.com/magento/magento2ce/pull/5000

Bamboo CI Builds

Related Pull Requests

https://github.com/magento/magento2ce/pull/5000

Checklist

  • PR is green on M2 Quality Portal
  • Jira issues have accurate summary, meaningful description and have links to relevant documentation at the story/task level
  • Semantic Version build failure is approved by architect (if build is red)
  • Pull Request approved by architect
  • Pull Request quality review performed by
  • All unstable functional acceptance tests are isolated (if any)
  • All linked Zephyr tests are approved by PO and have Ready to Use status
  • Travis CI build is green (for mainline CE only)
  • Jenkins Extended FAT build is green

davemacaulay and others added 17 commits November 4, 2019 11:06
…ize Options in Admin

- Add test coverage to swatches feature
# Conflicts:
#	app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/products/_import.less
#	app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/products/preview.js
#	app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/products/grid/preview.html
#	app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/products/preview.ts
…ize Options in Admin

- Create test for both carousel and grid appearance
# Conflicts:
#	app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeProductsActionGroup.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderProductsSection.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsCarouselTests.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsGridTests.xml
- Fix page builder JS and CSS are not loafing when static files are deployed in compact mode
# Conflicts:
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsCarouselTests.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsGridTests.xml
- Change protected property to private in Render controller
@davemacaulay davemacaulay merged commit 291df00 into magento:1.1-develop Nov 10, 2019
magento-devops-reposync-svc pushed a commit that referenced this pull request Apr 9, 2024
AC-11662 [PCI] - improve script rendering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants