Skip to content

[CMS Team 2 - Sprint 13] Changes to content type configuration, missing MFTF tests, custom container documentation, data migration bug and color picker bug #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

krissyhiserote
Copy link
Contributor

@krissyhiserote krissyhiserote commented Jul 27, 2018

Scope

Story

  • MC-532 Eliminate contradicting attributes (persist, virtual) and unnecessary nodes (complex_attribute, complex_property)
  • MC-536 Introduce Custom PageBuilder ContentType Container
  • MC-3226 Add Missing P0-P1 MFTF Tests For Divider
  • MC-3229 Add Missing P0-P1 MFTF Tests For Video
  • MC-3233 Add Missing P0-P1 MFTF Tests For Map
  • MC-3239 Add Missing P0-P1 MFTF Tests For Banner
  • MC-211 Bundle product details page

Bug

  • MC-3087 Overlay color for banner displays as input instead of Color input component
  • MC-3145 Data Migration Is Broken From Bluefoot To Mainline Pagebuilder

Bamboo CI Builds

Jenkins

Related Pull Requests

magento2ee#1
magento2-page-builder-ee#4

Checklist

  • PR is green on M2 Quality Portal
  • Jira issues have accurate summary, meaningful description and have links to relevant documentation at the story/task level
  • Semantic Version build failure is approved by architect (if build is red)
  • Pull Request approved by architect
  • Pull Request quality review performed by @tjwiebell
  • All unstable functional acceptance tests are isolated (if any)
  • All linked Zephyr tests are approved by PO and have Ready to Use status
  • Travis CI build is green (for mainline CE only)
  • Jenkins Extended FAT build is green

Michael Yu and others added 30 commits July 17, 2018 10:55
…input component

- Converted color input to color input component for banner, slide, and divider
- Updated product renderer to use product list as data-role
- Fixed product count to only be 1 instead of using eav to look for display that returns a string which throws a data type error
- Updated configuration schemas
- Removed style_properties and attributes from configuration on content types
- Updated test configuration
- Updated documentation
…input component

- Updating Divider & Slide tests for color picker fields
- Removing unused data
- Updating color picker selectors to be accurate
- Updated converter and reader for the removal of style-properties and attributes wrapper
- Updated configuration schemas for failing integration tests
- replace virtual and persist with persistance_mode in content type configuration
- Remove complex property and attribute from schema and update all content types
- Refactor framework so all attributes and properties use a reader
- Extract hard-coded reading of source driven attributes and properties into new readers
- Update documentation with these changes
- Update integration test data with the new schema of content type configuration
- Added documentation for creating custom content block
- Resolve some tslint issues
- Re-implement support for static attributes in configurable reader
- Add reader and name attributes to integration test expected results
- make default value readwrite for persistence_mode
- Added documentation for creating custom container content type
- Fixed minor configuration documentation
- Adding Move Map test
- Updating supporting selector
- Adding Move Banner test
- Updating supporting selector
- Renamed implementation class and updated codebase with new expected name
- Updating Delete Banner & Delete Map tests
- Updated delete divider test to now check stage and store front after save
- Updated delete divider test to be similar to map delete test
- add test for moving divider
- fix misspelling
- update delete video test to check stage and storefront
- Removed content_types, data_mapping, and groups nodes from config files
- Updated configuration schemas for the above changes
- Updated integration tests for above changes
- Updated documentation for above changes
Hwashiang Yu and others added 14 commits July 26, 2018 13:32
…-displays-as-input' into cms-team-2-sprint-13
- Adding Banner tests for updating all attributes and updating advanced attributes
- Updating Banner test for advanced attribute defaults
- Updating/Adding supporting data & action groups
- Updating Banner selectors
- Updating affected tests
- Deleting unused slider elements
- Fixing all failing Banner tests
- Rewriting Banner overlay & button tests to be valid
- Adding image cleanup to Banner tests
- Adding/Updating supporting data & selectors
- Fixing Banner button style test
- Updating empty banner selector & data
…to MC-3239-Add-Missing-P0-P1-MFTF-Tests-For-Banner
- Removed custom content block documentation
- Added screen shots of final work
- Removed widget section
- Fixed up documentation types
- Updated the styles to not use classes
- Removed custom content block documentation from navigation
- Fixing stepKeys for Banner never show buttons selection
- Adding appearance validation on Banner adv config update tests
- Adding additional validation to Banner on hover button tests
- Removing remaining hardcoded Banner elements
- Updating all affected tests
- Adding resizeWindow in Banner after steps
- skip move map test
@tjwiebell tjwiebell added the next label Jul 30, 2018
jcalcaben and others added 4 commits July 30, 2018 13:06
- Fixing Banner test failures
- Fixing some banner selectors
- Fixing a column testCaseId
- Fixing some Banner test cleanup steps
- Updated documentation according to architecture review
@tjwiebell tjwiebell added in progress and removed next labels Aug 1, 2018
@tjwiebell
Copy link
Contributor

Flaky StorefrontCustomerCheckoutTestWithMultipleAddressesAndTaxRates test added to MQE list and separate PR will be created in CE to mark as skipped.

@tjwiebell tjwiebell merged commit 2014962 into magento:develop Aug 2, 2018
@cspruiell cspruiell deleted the cms-team-2-sprint-13 branch September 14, 2018 18:46
magento-devops-reposync-svc pushed a commit that referenced this pull request Oct 6, 2021
[Platform Health] Dependency Updates & PHP8 Support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants