Issue 33297: Eliminate AspectMock from DataExtensionUtilTest #856
Conversation
magento-engcom-team
added
Partner: Atwix
partners-contribution
There was a problem hiding this comment.
Hello, @jilu1
This task was finished without creating new singletons, so it is not a blocker. You can proceed with the code review.
Thanks, Bohdan
| @@ -19,6 +19,8 @@ public static function setUpBeforeClass(): void | |||
| if (!self::fileExists(DOCS_OUTPUT_DIR)) { | |||
| mkdir(DOCS_OUTPUT_DIR, 0755, true); | |||
| } | |||
| // Should be used to clean AspectMock mocking before using PHPUnit mocking and Reflection. | |||
| AspectMock::clean(); | |||
There was a problem hiding this comment.
This Aspect Mock usage needs to be removed.
There was a problem hiding this comment.
Hello, @jilu1
It is temporarily. When all PRs merged we will proceed with the AspectMock eliminating in this class.
There was a problem hiding this comment.
@bohdan-harniuk
Got it. Thanks for the explanation!
|
Change looks good. Please address the comment inlined. |
| @@ -19,6 +19,8 @@ public static function setUpBeforeClass(): void | |||
| if (!self::fileExists(DOCS_OUTPUT_DIR)) { | |||
| mkdir(DOCS_OUTPUT_DIR, 0755, true); | |||
| } | |||
| // Should be used to clean AspectMock mocking before using PHPUnit mocking and Reflection. | |||
| AspectMock::clean(); | |||
There was a problem hiding this comment.
@bohdan-harniuk
Got it. Thanks for the explanation!
|
@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework |
|
@jilu1 the pull request successfully imported. |
karyna-t
deleted the
improvement/mftf-33297-eliminate-aspect-mock-from-DataExtensionUtilTest
branch
Description
Eliminated AspectMock usage from
dev/tests/unit/Magento/FunctionalTestFramework/DataGenerator/Util/DataExtensionUtilTest.phpFixed Issues (if relevant)
Contribution checklist