Eliminated Aspect Mock usage from FilesystemTest #833
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
codeception/aspect-mock
library is still not compatible with PHP 8.0 at the time of the creation of this ticket.To speed up Magento compatibility with new PHP versions we'd like to eliminate
codeception/aspect-mock
dependency from MFTF. This will make MFTF compatible with PHP 8.0 that is required for declaring the Magento core PHP 8 compatible as well.In order to do this existing unit tests using AspectMock should be refactored to use PHPUnit instead.
Task
Resolves magento/magento2#33291
Replace AspectMock with PHPUnit for
dev/tests/unit/Magento/FunctionalTestFramework/Config/Reader/FilesystemTest.php
in https://github.com/magento/magento2-functional-testing-framework repository.Example
Mocking an object using AspectMock (current):
Mocking an object using PHPUnit (refactored code):