Skip to content

MQE-2279: PWA - waitForPwaElementVisible method does not work in all … #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 28, 2020
Merged

MQE-2279: PWA - waitForPwaElementVisible method does not work in all … #798

merged 3 commits into from
Sep 28, 2020

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented Sep 17, 2020

…scenario's.

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

jilu1
jilu1 approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me. Make sure Devagouda Patil test and verify it works for use cases in PWA

@github-actions
Copy link

Coverage Report

Totals Coverage
Statements: 55.66% ( 3275 / 5884 )
Methods: 44.05% ( 248 / 563 )

@soumyau
Copy link
Contributor Author

soumyau commented Sep 28, 2020

Changes make sense to me. Make sure Devagouda Patil test and verify it works for use cases in PWA

reviewed and approved by Dev.

@soumyau soumyau merged commit 1f01cdd into develop Sep 28, 2020
soumyau added a commit that referenced this pull request Sep 28, 2020
@soumyau @tomreece @okolesnyk
MFTF 3.1.1 (#803)
c676031 
* MQE-2255: Migrate MFTF builds out of Travis

* MQE-2255: Migrate MFTF builds out of Travis

* MQE-2255: Migrate MFTF builds out of Travis

* MQE-2255: Migrate MFTF builds out of Travis

* MQE-2289: Cant generate urn catalog

* MQE-2279: PWA - waitForPwaElementVisible method does not work in all scenario's. (#798)

* MQE-2292: CHANGELOG.MD and version bump
3.1.1

Co-authored-by: Tom Reece <treece@adobe.com>
Co-authored-by: Alex Kolesnyk <kolesnyk@adobe.com>
@mmansoor-magento mmansoor-magento deleted the MQE-2279 branch November 4, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilu1 jilu1 jilu1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soumyau @jilu1