Fixed admin page url variables generation #78
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating a
Page
entity that has a parameter in it'surl
attribute and belongs to theadmin
area, e.g.<page name="AdminProductEditPage" url="catalog/product/edit/id/{{id}}/" area="admin" module="Magento_Catalog" parameterized="true">
then you call inside a test by using a created entity like this:After generating the test, the
goToProductEditPage1
step should look like this:$I->amOnPage("/" . getenv("MAGENTO_BACKEND_NAME") . "/catalog/product/edit/id/" . $this->createSimpleStandaloneProduct->getCreatedDataByName('id') . "/");
But it actually looks like this:
$I->amOnPage("/" . getenv("MAGENTO_BACKEND_NAME") . "/catalog/product/edit/id/$$createSimpleStandaloneProduct.id$$/");
So the
$$createSimpleStandaloneProduct.id$$
variable isn't being generated. This only happens to pages that belong to the admin area. This PR attempts to fix this by taking the variables the do thestr_replace
and first replacing the environment variables inside them before continuing with the code execution.Fixed Issues (if relevant)
Contribution checklist