Skip to content

Mqe 1997: Type float is wrongly treated as integer in assert actions #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2020

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Feb 13, 2020

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@jilu1 jilu1 changed the base branch from develop to master February 13, 2020 14:57
@coveralls
Copy link

coveralls commented Feb 13, 2020

Coverage Status

Coverage increased (+0.3%) to 51.373% when pulling ba72b5a on MQE-1997 into d632ab3 on master.

Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toNumber() will need update as well -

    private function toNumber($inStr)
    {
        $outStr = $this->stripQuotes($inStr);
        if ($this->hasDecimalPoint($outStr)) {
            return floatval($outStr);
        }
        return intval($outStr);
    }

@soumyau soumyau dismissed their stale review February 13, 2020 16:25

incorrect comments

soumyau
soumyau previously approved these changes Feb 13, 2020
@okolesnyk okolesnyk merged commit 8b33258 into master Feb 13, 2020
@soumyau soumyau deleted the MQE-1997 branch April 30, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants