Skip to content

MQE-1691: CREDS resolution does not occur from Suite <before> #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented Aug 9, 2019

Description

  • MQE-1691: CREDS resolution does not occur from Suite

Fixed Issues (if relevant)

#412

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@soumyau soumyau mentioned this pull request Aug 9, 2019
5 tasks
@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 56.135% when pulling c5083b1 on MQE-1691 into 9e9a20f on MFTF-2.4.4.

@tomreece tomreece self-requested a review August 9, 2019 18:04
@tomreece
Copy link
Contributor

tomreece commented Aug 9, 2019

Code looks good to me. I confirmed the generated suite contains the new use ..; line

However something is broken in my local environment that is preventing me from running suites so I am unable to full verify the suite runs at this time.

Copy link
Contributor

@tomreece tomreece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to verify this by generating and running a suite locally.

@KevinBKozan KevinBKozan merged commit 98db6ec into MFTF-2.4.4 Aug 14, 2019
@jilu1 jilu1 deleted the MQE-1691 branch February 6, 2020 16:55
magento-devops-reposync-svc pushed a commit that referenced this pull request Oct 29, 2024
…MFTF4.8.3

Merging PR from master back to develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants