Skip to content

MQE-1606: Mftf static check script should return error exit code when check fails #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 23, 2019

Conversation

tomreece
Copy link
Contributor

Description

The static-checks command now returns 1 if any errors are found and 0 if there are no errors.

Fixed Issues (if relevant)

https://jira.corp.magento.com/browse/MQE-1606

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Jul 18, 2019

Coverage Status

Coverage decreased (-1.6%) to 54.534% when pulling accceb8 on MQE-1606 into cd04795 on develop.

Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good, so good that they reveal the original implementation is a little off!
Fix the interface and the class to match your new pattern better, as it's a better design decision.

@tomreece
Copy link
Contributor Author

@KevinBKozan -- I acted on your feedback and refactored a few minor things along the way. Let me know if I made things better or worse.

@tomreece tomreece merged commit fa56508 into develop Jul 23, 2019
@tomreece tomreece deleted the MQE-1606 branch July 23, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants