Skip to content

MQE-1145: Update FrontendExecutor::authorize() method. #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2019
Merged

MQE-1145: Update FrontendExecutor::authorize() method. #290

merged 2 commits into from
Jan 23, 2019

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Jan 18, 2019

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Jan 18, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 57.054% when pulling fddb41f on MQE-1145 into e1cd4e1 on develop.

@KevinBKozan KevinBKozan requested review from KevinBKozan and removed request for KevinBKozan January 22, 2019 16:27
KevinBKozan
KevinBKozan approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tests are still running correctly.

@jilu1 jilu1 merged commit 1f0c73a into develop Jan 23, 2019
@jilu1 jilu1 deleted the MQE-1145 branch January 28, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jilu1 @coveralls @KevinBKozan