Skip to content

Use custom Backend domain, refactoring to Executors responsible for calling HTTP endpoints #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 10, 2018
Merged

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Nov 2, 2018

Description

Changes introduced to HTTP request executors to support custom Hosts. Fundamental goal was to support custom Backend domain. During the development I realised that Executors need refactor according to the static variables used.

Fixed Issues

  1. MFTF does not support custom Backend domain.
  2. Remove static variable use for carrying hostname
  3. MFTF did not handle REST API url with HTTPS

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-cicd2
Copy link

magento-cicd2 commented Nov 2, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Nov 2, 2018

Coverage Status

Coverage increased (+0.008%) to 57.054% when pulling 5d6ffcb on M2Coach:custom-domain-backend into bf2143d on magento:develop.

@okolesnyk okolesnyk self-requested a review November 5, 2018 09:00
Copy link
Member

@okolesnyk okolesnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbajsarowicz Looks good to me, but to be sure that this will not brake existing tests we need to run all existing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants