Skip to content

MQE-1181 #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 10, 2018
Merged

MQE-1181 #199

merged 11 commits into from
Aug 10, 2018

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Test runner now clears sessions between tests (after running test _after)
  • Suite running fixed

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

aljcalandra and others added 11 commits August 8, 2018 16:59
- Added null check for getDriver
- Added null check for error on after step
- Removed catches, removed line from functional suite yml
- changelog entry for 2.3.4 added
- version bump in composer and lock file
- reintroduced functional.suite.dist.yml restart: true
- MagentoWebDriver overwrites parent _after function and remaps it (to be called in TestContextExtension
- Static check ignore for PHPMD
- Moved reset session to after all test runs
- changed suites to not run suite_after if last test was a failure (compatibility issues)
- Suite After no longer resets WebDriver, allows Test after to fail naturally (and Suite After to run)
@KevinBKozan KevinBKozan merged commit 229b66e into develop Aug 10, 2018
@KevinBKozan KevinBKozan deleted the MQE-1181 branch August 10, 2018 19:56
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 56.173% when pulling 28a5f17 on MQE-1181 into 2282911 on develop.

magento-devops-reposync-svc pushed a commit that referenced this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants