EQPS-477: SVC Enhancements #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roribio
force-pushed
the
EQPS-307
branch
3 times, most recently
from
5680c92 to
da36c25
Compare
…the location of the ‘vendor’ folder
pdohogne-magento
approved these changes
Feb 27, 2020
| @@ -5,7 +5,12 @@ | |||
| * See COPYING.txt for license details. | |||
| */ | |||
|
|
|||
| require __DIR__ . '/../vendor/autoload.php'; | |||
| foreach ([__DIR__ . '/../../../autoload.php', __DIR__ . '/../vendor/autoload.php'] as $file) { | |||
There was a problem hiding this comment.
Should we do something if no autoload.php file was found?
There was a problem hiding this comment.
I don't think it's critical but we can throw an exception and suggest the user run the composer command. I don't see a scenario where the autoload.php file would be anywhere else.
roribio
added a commit
that referenced
this pull request
Feb 27, 2020
* Update README.md: Add information about releases and versioning * COMOPS-908: Updating compatibility with the BIC doc generator (#25) * EQPS-477: SVC Enhancements (#26) * EQPS-477: Dynamically set the correct path for autoload.php based on the location of the ‘vendor’ folder * EQPS-477: Make zend-stdlib a required dependency Co-authored-by: Peter Dohogne <pdohogne@adobe.com>
magento-cicd2
pushed a commit
that referenced
this pull request
Apr 27, 2021
[Arrows] MC-40411: SVC false-positive: removing the leading slash from a class name in di.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EQPS-477: SVC Enhancements to allow SVC tests on EQP submissions.
developandmasterREADME.mdfiles.zendframework/zend-stdlibas a required dependency instead of dev.autoload.phpfile whether running the tool independently or as a dependency.Manual testing scenarios
Contribution checklist