Skip to content

Added code style checks #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2019
Merged

Added code style checks #23

merged 2 commits into from
Dec 16, 2019

Conversation

slavvka
Copy link
Member

@slavvka slavvka commented Dec 13, 2019

Description (*)

  • Added code style checks
  • Fixed code style in code and tests

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@slavvka
- Added phpcs check
94e5cb4 
- Fixed code style
- Added phpcs check for tests
- Fixed tests code style
@lenaorobei
Copy link
Contributor

I would say we need to use https://github.com/magento/magento-coding-standard, but if there was a specific requirement to use PSR12 - I'm ok with this.

@slavvka
Copy link
Member Author

slavvka commented Dec 16, 2019

@lenaorobei There's no requirements to use PSR12. I just took it as the latest actual and by my own initiative. Is https://github.com/magento/magento-coding-standard applicable to non-Magento code? Because it is a standalone library which has nothing common with Magento

@lenaorobei
Copy link
Contributor

lenaorobei commented Dec 16, 2019 •
edited
Loading

@slavvka yes, there are some specific Magento checks but PSR2 is included. PRS12 is in progress right now, so probably you're right, if only code style is needed PSR12 is the best option.

@slavvka slavvka merged commit 72b35de into master Dec 16, 2019
@roribio roribio deleted the codestyle-checks branch February 28, 2020 17:38
magento-cicd2 pushed a commit that referenced this pull request Mar 25, 2021
@zakdma
Merge pull request #23 from magento-tsg/MC-35405
e64773c 
[Arrows] MC-35405: SVC false-positive: overriding public method in child class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

@magterskine magterskine Awaiting requested review from magterskine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavvka @lenaorobei