Skip to content

Class properties that have types should not require a DocBlock #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Class properties that have types should not require a DocBlock #406

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3332dba
Class properties that have types should not require a DocBlock
aligent-lturner Jun 24, 2022
9c71dd2
Revert accidental indenting
aligent-lturner Jun 24, 2022
4518aed
Fix multi-line function formatting
aligent-lturner Jun 24, 2022
661145b
Add extra use cases for typed class properties
aligent-lturner Jul 14, 2022
1e60800
Remove extra line
aligent-lturner Jul 14, 2022
ec3b1e4
Merge remote-tracking branch 'origin/develop' into feature/typed_clas…
aligent-lturner Apr 11, 2023
18bfbe7
Merge branch 'develop' into feature/typed_class_properties
ihor-sviziev Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix multi-line function formatting
  • Loading branch information
@aligent-lturner
aligent-lturner committed Jun 24, 2022
commit 4518aedbf2b5bc8fa552b648daa2b08004f05875
5 changes: 4 additions & 1 deletion Magento2/Sniffs/Commenting/ClassPropertyPHPDocFormattingSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,10 @@ public function processMemberVar(File $phpcsFile, $stackPtr)
// if the property has a valid type definition, we don't require a doc block
if (!$this->hasValidType($phpcsFile, $stackPtr)) {
$phpcsFile->addWarning(
'Missing PHP DocBlock for class property without valid type.', $stackPtr, 'Missing');
'Missing PHP DocBlock for class property without valid type.',
$stackPtr,
'Missing'
);
}
// no comment, so nothing further to process
return;
Expand Down