Skip to content

MC-19366: Adds GraphQL sniffs #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Sep 25, 2019
Merged

MC-19366: Adds GraphQL sniffs #141

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
ba0bbce
MC-19366: Adds a tokenizer for GraphQL schema files
jean-bernard-valentaten Sep 6, 2019
6003dcd
MC-19366: Adds sniff for type names
jean-bernard-valentaten Sep 6, 2019
8cb90c8
MC-19366: Improves GraphQL tokenizer by making use of webonyx/graphql…
jean-bernard-valentaten Sep 9, 2019
586244a
MC-19366: Adds sniff for field names
jean-bernard-valentaten Sep 10, 2019
27e99de
MC-19366: Adds sniff for argument names
jean-bernard-valentaten Sep 11, 2019
47fb203
MC-19366: Adds sniff for top level fields
jean-bernard-valentaten Sep 11, 2019
6f5d136
MC-19366: Downgrade of package webonyx/graphql-php to match lowest ph…
jean-bernard-valentaten Sep 11, 2019
7a5b266
MC-19366: Fixes code style issues
jean-bernard-valentaten Sep 11, 2019
e310c5c
MC-19366: Fixes code style issue
jean-bernard-valentaten Sep 11, 2019
2a8d521
MC-19366: Deactivates field name validation
jean-bernard-valentaten Sep 12, 2019
505c9b2
MC-19366: Adds sniff for valid enum values
jean-bernard-valentaten Sep 12, 2019
19cdbec
MC-19366: Activates sniff for enum values
jean-bernard-valentaten Sep 12, 2019
01eee92
MC-19366: Fixes file doc
jean-bernard-valentaten Sep 12, 2019
d99c922
MC-19366: Fixes that tokenizer for GraphQL files could not be loaded …
jean-bernard-valentaten Sep 13, 2019
49f0b0b
MC-19366: Fixes that agruments with directives would result in errone…
jean-bernard-valentaten Sep 13, 2019
0b8eeaa
MC-19366: Fixes that field name validation was executed although it s…
jean-bernard-valentaten Sep 13, 2019
571b642
MC-19366: Fixes that field and argument names were marked as entities…
jean-bernard-valentaten Sep 13, 2019
c574003
MC-19366: Fixes code style issue
jean-bernard-valentaten Sep 13, 2019
43ef0a4
MC-19366: Removes obsolete TODOs
jean-bernard-valentaten Sep 16, 2019
c539ed4
MC-19366: Fixes order of rules and silences GraphQL field name valida…
jean-bernard-valentaten Sep 17, 2019
af9c041
MC-19366: Fixes that list type and non null arguments would not be pa…
jean-bernard-valentaten Sep 17, 2019
c4069e0
MC-19366: Fixes that enum values with directives would be parsed as e…
jean-bernard-valentaten Sep 17, 2019
874c9d7
MC-19366: Fixes code style issue
jean-bernard-valentaten Sep 17, 2019
4d99ee4
MC-19366: Fixes warning when composer install was run
jean-bernard-valentaten Sep 18, 2019
e252b19
MC-19366: Fixes invalid tag in PHPDoc
jean-bernard-valentaten Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
MC-19366: Deactivates field name validation
  • Loading branch information
@jean-bernard-valentaten
jean-bernard-valentaten committed Sep 12, 2019
commit 2a8d52183bb612c3e4b520fb9b6d8a664932d9a9
9 changes: 5 additions & 4 deletions Magento2/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,10 +526,11 @@
<severity>6</severity>
<type>warning</type>
</rule>
<rule ref="Magento2.GraphQL.ValidFieldName">
<severity>6</severity>
<type>warning</type>
</rule>
<!-- Field name validation deactivated as per request https://github.com/magento/magento-coding-standard/pull/141#discussion_r323349939 -->
<!-- <rule ref="Magento2.GraphQL.ValidFieldName">-->
<!-- <severity>6</severity>-->
<!-- <type>warning</type>-->
<!-- </rule>-->
<rule ref="Magento2.GraphQL.ValidArgumentName">
<severity>6</severity>
<type>warning</type>
Expand Down