Skip to content

add configurable node version #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add configurable node version #335

wants to merge 1 commit into from

Conversation

Morgy93
Copy link
Member

@Morgy93 Morgy93 commented Nov 17, 2021

Description

It adds the ability to install a custom node version.

Manual testing scenarios

  1. Use php-cli image "as-is" and check if current node lts is installed.
  2. Set NODE_VERSION to like 16 and check if node 16 is installed.

Release notes

Added the ability to set a custom node version via NODE_VERSION.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • Pull request introduces user-facing changes and includes meaningful release notes and documentation
  • All commits are accompanied by meaningful commit messages

@magento-cloud-ft-jenkins-svc

Unit & Integration Test Results

✅  All unit and integration tests have passed.

Unit Test Output

PHPUnit 8.5.21 by Sebastian Bergmann and contributors.

......                                                              6 / 6 (100%)

Time: 315 ms, Memory: 12.00 MB

OK (6 tests, 18 assertions)

Generating code coverage report in Clover XML format ... done [798 ms]

Integration Test Output

PHPUnit 8.5.21 by Sebastian Bergmann and contributors.

..................                                                18 / 18 (100%)

Time: 4.89 seconds, Memory: 36.00 MB

OK (18 tests, 18 assertions)

This comment was generated by Jenkins job magento-cloud-docker/unit build 67.

@magento-cloud-ft-jenkins-svc

Static Analysis & Code Style Results

✅  All static analysis and code style checks have passed.

PHP Codesniffer Output

............................................................ 60 / 89 (67%)
.............................                                89 / 89 (100%)


Time: 6.05 secs; Memory: 12MB


PHP Mess Detector Output


Found 0 violations and 0 errors in 2954ms

�[32mNo mess detected�[0m

PHPStan Output


 [OK] No errors                                                                 


This comment was generated by Jenkins job magento-cloud-docker/static build 68.

@magento-cloud-ft-jenkins-svc

Functional Acceptance Test Results

✅  All functional acceptance tests have passed.

PHP 7.2

  • ✅  Elasticsearch72Cest
  • ✅  Services72Cest
  • ✅  Acceptance72Cest

PHP 7.3

  • ✅  Elasticsearch73Cest
  • ✅  ServicesCest
  • ✅  Acceptance73Cest

PHP 7.4

  • ✅  MailHogCest
  • ✅  DeveloperCest
  • ✅  ElasticsearchCest
  • ✅  AcceptanceCest

This comment was generated by Jenkins job magento-cloud-docker/functional build 93.

@YPyltiai YPyltiai added the improvement issue type label Dec 2, 2021
@BaDos
Copy link
Contributor

BaDos commented Jul 21, 2022

The internal task MCLOUD-9012 was created to process this PR

@BaDos BaDos self-assigned this Aug 31, 2022
@Morgy93 Morgy93 closed this by deleting the head repository Sep 19, 2023
@m2-community-project m2-community-project bot removed the Progress: review PR/issue status label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement issue type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants