MAGECLOUD-3446: Add ICU and Phonetic Plugins to Elasticsearch Docker image #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftedreality
approved these changes
Jun 18, 2019
|
QA approved |
ngreimel-lt
pushed a commit
to ngreimel-lt/magento-cloud-docker
that referenced
this pull request
Jun 25, 2019
* upstream/master: MAGECLOUD-3357: [Cloud Docker] Changes in .magento.app.yaml should affect php modules (magento#25) MAGECLOUD-3446: Add ICU and Phonetic Plugins to Elasticsearch Docker Image (magento#26) MAGECLOUD-3582: [Cloud Docker] Default path during bash connection sh… (magento#24) MAGECLOUD-3441: [Cloud Docker] Resolve Problem with SCD on Build Phas… (magento#23)
YPyltiai
added
Progress: accept
mmansoor-magento
pushed a commit
that referenced
this pull request
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a developer I want my Docker containers to match P.sh's environments as closely as possible. The Elasticsearch service in P.sh has the ICU (analysis-icu) and Phonetic (analysis-phonetic) plugins installed by default. Those plugins should also be added to our Docker images.
Manual testing scenarios
To build image from the custom branch you need to use
then check that ES has
analysis-icuandanalysis-phoneticplugins.Contribution checklist