Skip to content

Hot fix: Plugin name is not unique #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Alkar778
Copy link
Contributor

Description

Fixed Issues (if relevant)

  1. magento/magento-cloud-components#<issue_number>: Issue title
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Release notes

For user-facing changes, add a meaningful release note. For examples, see Magento Cloud Components release notes.

Associated documentation updates

Add link to Magento DevDocs PR or Issue, if needed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • Pull request introduces user-facing changes and includes meaningful updates for any required release notes and documentation changes
  • All commits are accompanied by meaningful commit messages

@magento-cloud-ft-jenkins-svc

Unit Test Results

✅ All unit tests have passed.

Unit Test Output

PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

Error:         Incorrect whitelist config, no code coverage will be generated.

.............                                                     13 / 13 (100%)

Time: 86 ms, Memory: 18.79 MB

OK (13 tests, 32 assertions)

This comment was generated by Jenkins job magento-cloud-components/unit build 3.

@magento-cloud-ft-jenkins-svc

Static Analysis & Code Style Results

❌ One or more static analysis or code style checks have failed.

PHP Codesniffer Output

........................... 27 / 27 (100%)


Time: 2.52 secs; Memory: 18.79MB


PHP Mess Detector Output


FILE: /var/jenkins/workspace/magento-cloud-components/static/Model/Observer/CacheFlushAll.php
---------------------------------------------------------------------------------------------
 38 | �[31mVIOLATION�[0m | Avoid unused parameters such as '$observer'.

Found 1 violation and 0 errors in 321ms

PHPStan Output


������  You're running a really old version of PHPStan.���

The last release in the 0.11.x series with new features
and bugfixes was released on October 22nd 2019,
that's 612 days ago.

Since then more than 50 new PHPStan versions were released
with hundreds of new features, bugfixes, and other
quality of life improvements.

To learn about what you're missing out on, check out
this blog with articles about the latest major releases:
https://phpstan.org/blog

Historically, the main two blockers preventing
people from upgrading were:
1) Composer conflicts with other dependencies.
2) Errors discovered by the new PHPStan version and no time
   to fix them to get to a green build again.

Today, neither of them is a problem anymore thanks to:
1) phpstan/phpstan package having zero external dependencies.
2) Baseline feature letting you use the latest release
   right away even with pre-existing errors.
   Read more about it here: https://phpstan.org/user-guide/baseline

Upgrade today to PHPStan 0.12 by using
"phpstan/phpstan": "^0.12" in your composer.json.


������  You're running a really old version of PHPStan.���

The last release in the 0.11.x series with new features
and bugfixes was released on October 22nd 2019,
that's 612 days ago.

Since then more than 50 new PHPStan versions were released
with hundreds of new features, bugfixes, and other
quality of life improvements.

To learn about what you're missing out on, check out
this blog with articles about the latest major releases:
https://phpstan.org/blog

Historically, the main two blockers preventing
people from upgrading were:
1) Composer conflicts with other dependencies.
2) Errors discovered by the new PHPStan version and no time
   to fix them to get to a green build again.

Today, neither of them is a problem anymore thanks to:
1) phpstan/phpstan package having zero external dependencies.
2) Baseline feature letting you use the latest release
   right away even with pre-existing errors.
   Read more about it here: https://phpstan.org/user-guide/baseline

Upgrade today to PHPStan 0.12 by using
"phpstan/phpstan": "^0.12" in your composer.json.


 [OK] No errors                                                                 


This comment was generated by Jenkins job magento-cloud-components/static build 3.

@magento-cloud-ft-jenkins-svc

Functional Acceptance Test Results

✅  All functional acceptance tests have passed.

PHP 7.1

  • ✅  Acceptance71Cest

PHP 7.2

  • ✅  Acceptance72Cest

PHP 7.3

  • ✅  Acceptance73Cest

PHP 7.4

  • ✅  AcceptanceCest

This comment was generated by Jenkins job magento-cloud-components/functional build 4.

Copy link

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent spot!
You need to sign the Adobe CLA and deal with the test fails

@BarnyShergold
Copy link

Closing due to lack of response

magento-devops-reposync-svc pushed a commit that referenced this pull request Jun 3, 2025
Cloud release cloud-components 1.1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants