-
Notifications
You must be signed in to change notification settings - Fork 20
MCLOUD-6958: Command cache:evict does not support L2 cache configuration #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Model/Cache/Evictor.php
Outdated
* @param string $configKey | ||
* @return string | ||
*/ | ||
private function getCacheConfigValue($cacheConfig, $configKey) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add return type declaration to new functions
private function getCacheConfigValue($cacheConfig, $configKey): string
and for isCacheConfigValid()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NadiyaS
CR Notes - fixed
fd0f5ae
@yvoronoy may you please take a look. I got next error during testing:
|
@yvoronoy Build failed. Red tests |
@andriyShevtsov tests are red because we need to create a PR from this repo, we don't run tests if the PR is from an external repo. |
Ok. Manual QA already done here. Approved |
I will create the PR, just in case, to run tests |
bump version to 1.1.1
Description
Command for cache key eviction does not support Redis L2 Cache Configuration.
https://jira.corp.magento.com/browse/MCLOUD-6958
Manual testing scenarios
Expected Result
L2 Cache Configuration can be parsed and evict expired keys in Redis
Release notes
Updated the
php bin/magento cache:evict
command to support the default L2 Cache Configuration for the Redis service.Contribution checklist