-
Notifications
You must be signed in to change notification settings - Fork 20
Logging improvements #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add proper description, notes etc
Ensure Travis tests pass.
@BarnyShergold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepted that Travis is failing for unknown reasons
@Alkar778 I've created separate PR from this pr for test running and static tests failed
Please fix. |
@oshmyheliuk |
@oshmyheliuk |
@Alkar778 Static tests are ok, but functional failed
|
public function getTrace() | ||
{ | ||
$trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS); | ||
foreach ($trace as $index => $line) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add validation if elements of array $line
is set.
$line['function']
$line['class']
$line['file']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I reproduce case when the file key undefined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such error happening during setup:install
.
https://travis-ci.com/github/magento/magento-cloud-components/jobs/378018983
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
QA approved |
Static test fix
Description
This PR reduces the size of cache.log file
Manual testing scenarios
Expected Result
Release notes
Reduced the size of the cache.log file to improve performance.
Associated documentation updates
Add link to Magento DevDocs PR or Issue, if needed.
Contribution checklist