Skip to content

SWAT-430: Extended debugging information about cache & indexer invali… #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Alkar778
Copy link
Contributor

@Alkar778 Alkar778 commented May 28, 2020

…dation

Description

Internal issue in Jira https://jira.corp.magento.com/browse/MCLOUD-6156
This PR adds extended logging information.

Manual testing scenarios

  1. Install vanilla Magento with this module.
  2. Run php bin/magento setup:di:compile
  3. Run php bin/magento indexer:reindex
  4. File indexation.log has been created in var/log directory with 14 records
  5. Remove var/log/indexation.log and var/log/cache.log
  6. Run php bin/magento cache:flush
  7. File cache.log has been created in var/log directory with 2 records
  8. Remove var/log/cache.log
  9. Run php bin/magento cache:clean
  10. File cache.log has been created in var/log directory with 19 records

Release notes

Improved logging–Added logging to track cache invalidation and full reindex events.

Associated documentation updates

Add link to Magento DevDocs PR or Issue, if needed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • Pull request introduces user-facing changes and includes meaningful release notes and documentation
  • All commits are accompanied by meaningful commit messages

@YPyltiai YPyltiai added Progress: review PR/issue status Release: 1.0.4 MCC Release labels May 29, 2020
@YPyltiai
Copy link

@Alkar778 , builds look to be red. Please look into that once you have a chance.

@oshmyheliuk
Copy link
Contributor

@YPyltiai builds are red as this is PR from a forked repo.

@oshmyheliuk oshmyheliuk reopened this May 29, 2020
* Apply model save operation
*
* @param Observer $observer
* @throws \Magento\Framework\Validator\Exception
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with use short usage

@oshmyheliuk
Copy link
Contributor

@Alkar778 please fix static errors:
You can run static tests locally via command composer:test

FILE: ...avis/build/magento/magento-cloud-components/Model/Logger/Handler/Debug.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 10 | ERROR | Missing doc comment for class Debug
--------------------------------------------------------------------------------
FILE: ...is/build/magento/magento-cloud-components/Model/Observer/CacheFlushAll.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 15 | ERROR | Missing doc comment for class CacheFlushAll
--------------------------------------------------------------------------------
FILE: .../magento/magento-cloud-components/Model/Observer/IndexerStateSaveAfter.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 17 | ERROR | Missing doc comment for class IndexerStateSaveAfter
--------------------------------------------------------------------------------
FILE: .../travis/build/magento/magento-cloud-components/Model/Indexation/Logger.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 14 | ERROR | Missing doc comment for class Logger
--------------------------------------------------------------------------------

@oshmyheliuk
Copy link
Contributor

oshmyheliuk commented Jun 3, 2020

Tests are green #27

@shiftedreality shiftedreality added Progress: testing in progress PR/issue status and removed Progress: review PR/issue status labels Jun 3, 2020
@shiftedreality
Copy link
Member

@Alkar778 do you want us to QA this PR or you can make it with your team?

@Alkar778
Copy link
Contributor Author

Alkar778 commented Jun 4, 2020

@shiftedreality
I've already done a QA but it would be great if you will able to do QA as well.

@shiftedreality
Copy link
Member

@Alkar778 could you provide a testing scenario for our QA?

@Alkar778 Alkar778 removed their assignment Jun 5, 2020
@Alkar778
Copy link
Contributor Author

Alkar778 commented Jun 5, 2020

@shiftedreality

Test scenario:

  1. Install vanilla Magento with this module.

  2. Run php bin/magento setup:di:compile

  3. Run php bin/magento indexer:reindex

  4. File indexation.log has been created in var/log directory with 14 records

  5. Remove var/log/indexation.log and var/log/cache.log

  6. Run php bin/magento cache:flush

  7. File cache.log has been created in var/log directory with 2 records

  8. Remove var/log/cache.log

  9. Run php bin/magento cache:clean

  10. File cache.log has been created in var/log directory with 19 records

@andriyShevtsov
Copy link
Contributor

QA approved

@andriyShevtsov andriyShevtsov added the Progress: approved PR/issue status label Jun 5, 2020
@oshmyheliuk oshmyheliuk merged commit 6066080 into magento:develop Jun 5, 2020
magento-devops-reposync-svc pushed a commit that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: approved PR/issue status Release: 1.0.4 MCC Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants