Anyway to disable stock reservation?

[asim-vax]

Summary (*)

We are noticing an issue where the default behaviour of MSI (no sources or stock set up) is that as an item is sold, it adds a record to inventory_reservation. And salable quantity is reduced.

We manage our stock in another system, and update the quantity field as orders come in. This is causing issues as suddenly the salable quantities are lowering, and never reset.

Is there a way to reset this salable quantity?
Is there a way to disable this in store -> config, or via config.php by disabling modules?

Examples (*)

As you can see here, some salable quantity is the same as quantity, but some are 0, and some are lower. As we manage stock elsewhere, and update magento, the quantity is the field we rely on. It should reduce by 1 as an order is placed, like prior default magento behaviour.

Proposed solution

A way to reset MSI, or to not fill the reservation table so our salable quantity is artificially lower than it should be.

[csdougliss]

MSI has dependencies on reservation code.

I've added the following plugin override:

/**
 * Prevent append reservation if manage_reservations is set to 0
 */
class PreventAppendReservationOnNotManageItemsInStockPlugin extends \Magento\InventorySales\Plugin\InventoryReservationsApi\PreventAppendReservationOnNotManageItemsInStockPlugin
{
    /**
     * @var GetStockItemConfigurationInterface
     */
    private $getStockItemConfiguration;

    /**
     * @var StockConfigurationInterface
     */
    private $stockConfiguration;

    /**
     * @param GetStockItemConfigurationInterface $getStockItemConfiguration
     * @param StockConfigurationInterface $stockConfiguration
     */
    public function __construct(
        GetStockItemConfigurationInterface $getStockItemConfiguration,
        StockConfigurationInterface $stockConfiguration
    ) {
        $this->getStockItemConfiguration = $getStockItemConfiguration;
        $this->stockConfiguration = $stockConfiguration;
    }

    /**
     * @param AppendReservationsInterface $subject
     * @param \Closure $proceed
     * @param ReservationInterface[] $reservations
     *
     * @throws LocalizedException
     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
     */
    public function aroundExecute(AppendReservationsInterface $subject, \Closure $proceed, array $reservations)
    {
        if (!(bool)$this->stockConfiguration->getDefaultConfigValue('manage_reservations')) {
            return;
        }

        return parent::aroundExecute($subject, $proceed, $reservations);
    }
}

And added a new back end option Manage Reservations.

Will this cause any other issues?? e.g. when the item is shipped for example?

Have to add the variables again as they are private 👎

[ishakhsuvarov]

Generally we do not advise to disable reservations mechanism as it might cause undesired effects in multiple scenarios across the system.

@asim-vax Scenario you are describing should work fine when you have Manage Stock = False on the product level, this way you would tell Magento Inventory to stop trying to manage stock for you. Is there any specific reason you decided not to use it?

[Swahjak]

We are using an external system that (by default) communicates the salable stock to Magento. I'm going to go ahead and assume that every Magento 1 webshop with an external inventory worked this way, since Magento 1 didn't have a reservation logic (and a wms / erp usually provides this functionality).

Now both Magento 2 and the external system will have their own 'truth' about what the available stock level is. The reservation logic is great if no external systems are used, but if an external system is used that system should be the source of truth, not Magento. One solution could be to revert to the legacy inventory, but I don't really like working with things that are going to be legacy. Besides, there are a lot of great features in MSI that I do want to use.

[csdougliss]

@ishakhsuvarov If you have say, 10 in stock, you want manage stock to be enabled as you only want to sell what you have and for magento to reduce the count.

So you cannot turn off Manage stock even if you have an external system.

[Swahjak]

I'm not talking about turning off 'Manage stock' but a simple decrease would suffice since we rely on an external system to actually 'compute' what we want to happen to the stock. If a refund is created, the external system will decide whether or not the item should be returned to stock.

Take the following scenario;

• We have a stock of 2 Product A
• User buys product A
• Magento decreases salable quantity by 1 resulting in 1 salable unit
• External system decreases salable quantity by 1 resulting in 1 salable unit
• External system pushes stock level back to Magento
• Product A is no longer salable since the quantity is 1, reservation is 1, and salable quantity is 0

Now we could argue that the external system should be pushing the quantity, not the salable quantity. But what if I have some other logic in my external system? Let's say a POS that can also reserve stock in my external system. Now my external system communicates a stock level of 2 while only 1 is available.

Point being; My external system is the source of truth, not Magento. Magento is 'just' my storefront. Something which worked perfectly before MSI. (Not bashing on MSI, just stating the facts).

[franckgarnier21]

Totally agree with @Swahjak.

The logic reservation can be complex and it has to be handle by the erp.

I have the same issue.

I have two solutions.

1/ Provide a view of Magento reservations state to the erp.
2/ override reservations logic to deduct source qty and not create reservations.

Thanks,

[maghamed]

hey guys @Swahjak @franckgarnier21 @craigcarnell ,

I totally agree with your business reasoning, and that for many merchants Magento is "just" a storefront while the real decision-making system is periodically sync-up with Magento providing the reliable data for transactional operations processing, being a source of truth.
Moreover internally we deal with quite the same situation while integrating Magento Order Management (MOM) with MSI, where MOM system in our case is a source of truth, which is in charge for calculation of an aggregation (stock) and periodically sync up with Magento updating the Inventory data we have there.

MSI was designed taking in mind all the possible integration strategies with 3rd party systems.

That's why we introduced \Magento\InventorySalesApi\Api\PlaceReservationsForSalesEventInterface interface which is an entry point for all reservations created in Magento. You can look through the usage of the interface, it's called for Order Placement, Returns, Order cancellation, and Shipment handling both negative and positive (compensational) reservations will go through this entry point.

The trickiest part for us is that we can't predict what particular integration set up for your case, as there could be different options which impact the Quantity calculation.
For example,

1. Magento used as a storefront, and there is an external 3rd party system which is a source of truth for Inventory data.
2. Order placed in Magento.
3. Magento creates a corresponding Stock reservation. But the order is not handled yet, order status is Pending.
4. External system sync-up with Magento providing "correct" Inventory data from that system

The question is what to do with an open reservation in Magento created as a result of order placement? Whether the order is already counted and Quantities are adjusted accordingly in the external system or not?
We don't know the answers to these questions, thus there could not be generic handling. But you as an extension developer know how both systems work and whether the Order already adjusted quantities coming from external ERP or not. Thus, you are in charge of customizing Magento behavior via pluginization or replacement of PlaceReservationsForSalesEventInterface service.

You no need to switch off Manage Stock in Magento in this case, moreover doing so you will lose an explicit extension point provided exactly for this customization, but you need to add your behavior which will impact on how Reservations are created.

For example, for MSI and MOM integration we will handle just the initial negative reservation created at the time of Order placement, all other reservations (on shipment and refund) are swallowed, as they are managed by MOM. The order placement reservation publishes a message to a Queue (in RabbitMQ) which is then handled by a subscriber on the MOM side. Thus, we always consider that Stock Quantities coming from MOM always include all the Orders placed in Magento.

Here you can watch a presentation by @vadimjustus where he is describing different integration strategies with Magento + MSI based on TechDivision projects - https://www.youtube.com/watch?v=RoIEaoVm4mU

[micwallace]

Rather than disabling the reservation in favor of deduction I propose the following so that stock is reserved until the order hits the ERP system:

1. Order is placed and reservation entry is added.
2. The order is synced with the ERP system. An additional reservation entry is added to cancel out the order_placed reservation and bring the total to 0. Stock can be deducted from the source quantity at that time too, depending on how often your ERP stock gets synced.
3. A plugin prevents default reservation logic after shipment, invoice or cancellation if the reservation total is already 0.

This solution has the benefit that orders that aren't yet synced still count towards the salable quantity.

I'll be doing this for our implementation on Monday and will post the code once I'm done.

[gavinhoman]

We are experiencing the same issues for a project and need to remove the 'reservation' feature completely and allow 'saleable stock' to be the true source of inventory.

Has anybody come up with a solution to this yet?

[franckgarnier21]

You can play with the observers and plugin in order to remove the reservation additional.
At your own risk.
On my side I succeed to decrease the physical stock at invoice creation and not during shipment.

[darrenbrooksnm]

We are experiencing the same issues for a project and need to remove the 'reservation' feature completely and allow 'saleable stock' to be the true source of inventory.

Has anybody come up with a solution to this yet?

You can turn it off but disabling these modules and then running the usual setup:upgrade... etc.

php bin/magento module:disable -f Magento_Inventory Magento_InventoryAdminUi Magento_InventoryApi Magento_InventoryBundleProduct Magento_InventoryBundleProductAdminUi Magento_InventoryCatalog Magento_InventorySales Magento_InventoryCatalogAdminUi Magento_InventoryCatalogApi Magento_InventoryCatalogSearch Magento_InventoryConfigurableProduct Magento_InventoryConfigurableProductAdminUi Magento_InventoryConfigurableProductIndexer Magento_InventoryConfiguration Magento_InventoryConfigurationApi Magento_InventoryGroupedProduct Magento_InventoryGroupedProductAdminUi Magento_InventoryGroupedProductIndexer Magento_InventoryImportExport Magento_InventoryIndexer Magento_InventoryLowQuantityNotification Magento_InventoryLowQuantityNotificationAdminUi Magento_InventoryLowQuantityNotificationApi Magento_InventoryMultiDimensionalIndexerApi Magento_InventoryProductAlert Magento_InventoryReservations Magento_InventoryReservationsApi Magento_InventoryCache Magento_InventorySalesAdminUi Magento_InventorySalesApi Magento_InventorySalesFrontendUi Magento_InventoryShipping Magento_InventorySourceDeductionApi Magento_InventorySourceSelection Magento_InventorySourceSelectionApi Magento_InventoryShippingAdminUi Magento_InventoryDistanceBasedSourceSelectionAdminUi Magento_InventoryDistanceBasedSourceSelectionApi Magento_InventoryElasticsearch Magento_InventoryExportStockApi Magento_InventoryReservationCli Magento_InventoryExportStock Magento_CatalogInventoryGraphQl Magento_InventorySetupFixtureGenerator

[gavinhoman]

@darrenbrooksnm thanks for the reply. This looks like ALL inventory management would be disabled? We still want to manage inventory so that 'saleable' stock is the same as 'quantity' so just do away with the reservation feature in M2.

So if an item has a quantity of 10 then a maximum of 10 units can be purchased by a customer.