Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

GraphQL: Comparison list coverage #8646

Merged
merged 21 commits into from
Feb 8, 2021
Merged

GraphQL: Comparison list coverage #8646

merged 21 commits into from
Feb 8, 2021

Conversation

keharper
Copy link
Contributor

@keharper keharper commented Feb 8, 2021

Purpose of this pull request

This pull request (PR) completes work started in #8644. I created a separate branch so that I have better control of pushing multi-topic changes.

whatsnew
Added support for comparison lists. Shoppers can create and delete comparison lists, and add and remove items to the comparison lists. In addition, shoppers that create a comparison list as a guest can log in as a customer and retain their comparison lists.

@keharper keharper added Community Docs impacted by community code contribution New Topic A major update published as an entirely new document 2.4.2 labels Feb 8, 2021
@keharper keharper self-assigned this Feb 8, 2021
@keharper keharper requested a review from dobooth February 8, 2021 04:09

Attribute | Data Type | Description
--- | --- | ---
`result` | Boolean! | A value of `true` indicates the compare list has been deleted successfully. Otherwise, the value is `false`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`result` | Boolean! | A value of `true` indicates the compare list has been deleted successfully. Otherwise, the value is `false`
`result` | Boolean! | A value of `true` indicates the compare list has been deleted successfully. Otherwise, `false`

@keharper
Copy link
Contributor Author

keharper commented Feb 8, 2021

running tests

@keharper keharper enabled auto-merge February 8, 2021 22:18
@keharper keharper merged commit 5087e6a into 2.4.2-develop Feb 8, 2021
@ghost
Copy link

ghost commented Feb 8, 2021

Hi @keharper, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper keharper deleted the compare-lists branch February 8, 2021 22:35
@jeff-matthews jeff-matthews added the Internal Dev Differentiates work between community and Magento staff label Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.4.2 Community Docs impacted by community code contribution Internal Dev Differentiates work between community and Magento staff New Topic A major update published as an entirely new document Progress: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants