Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Cloud Patches 1.0.9 Release #8577

Merged
merged 9 commits into from
Feb 1, 2021
Merged

Cloud Patches 1.0.9 Release #8577

merged 9 commits into from
Feb 1, 2021

Conversation

bdenham
Copy link
Contributor

@bdenham bdenham commented Jan 28, 2021

Purpose of this pull request

This pull request (PR) updates Cloud Patches release notes for version 1.0.9.

Preview from local build

image

Affected DevDocs pages

https://devdocs.magento.com/cloud/release-notes/mcp-release-notes.html

whatsnew
Cloud Patches 1.0.9 release notes.

@bdenham bdenham self-assigned this Jan 28, 2021
@bdenham bdenham added 2.3.x Magento 2.3 related changes Progress: ready for review and removed Progress: review labels Jan 28, 2021
@bdenham bdenham added 2.4.x Magento 2.4.x related changes Internal Dev Differentiates work between community and Magento staff Progress: ready for review and removed 2.3.x Magento 2.3 related changes Progress: review labels Jan 28, 2021
@bdenham bdenham changed the title WIP cloud-patches release notes Cloud Patches 1.0.9 Release Jan 28, 2021
@bdenham bdenham changed the title Cloud Patches 1.0.9 Release [DRAFT] Cloud Patches 1.0.9 Release Jan 28, 2021
@bdenham bdenham added the Major Update Significant original updates to existing content label Jan 28, 2021
@bdenham bdenham marked this pull request as ready for review January 28, 2021 17:18
@bdenham bdenham changed the title [DRAFT] Cloud Patches 1.0.9 Release Cloud Patches 1.0.9 Release Jan 28, 2021
Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Silently failed" 😲
Nice.

Comment on lines 27 to 31
- {:.fix} **Compatibility with PHP 7.4**—Fixed a compatibility issue with PHP 7.4.
- {:.fix} **Deprecated patches become visible**—Fixed issue in which deprecated patches become visible is the patches table after applying a replacement patch that contains the entire contents of the deprecated patch. This could happen if you applied a patch that combined several other patches.<!--MC-40626-->
- {:.fix} **Layered navigation**—Fixed the issue that prevented the layered navigation from showing all options when the B2B Shared Catalog was enabled.<!--MCLOUD-6923-->
- {:.fix} **Silent failures when applying patches**—Fixed an issue in which the `git apply` command silently failed to apply patches in some environments.<!--MC-40529-->

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to do it better, but maybe we can separate or mark where is actually a patch for Magento itself and where are fixes or changes in magento-cloud-patches.
So there is only one patch for Magento (MCLOUD-6923 Layered navigation) and three others task are just changes in magento-cloud-patches

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the fixes to magento-cloud-patches can be listed with {:.fix} bullet and the new patch should be called out by name in bold with description following, as in previous release notes. That seems to be a readable way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. I get it now. My first patch job. Thanks for the guidance!

@bdenham bdenham enabled auto-merge (squash) January 29, 2021 18:26
@bdenham
Copy link
Contributor Author

bdenham commented Jan 29, 2021

running tests

@bdenham bdenham disabled auto-merge January 29, 2021 18:46
@bdenham
Copy link
Contributor Author

bdenham commented Feb 1, 2021

running tests

@bdenham bdenham enabled auto-merge (squash) February 1, 2021 20:17
@bdenham bdenham merged commit 73930f8 into master Feb 1, 2021
@ghost
Copy link

ghost commented Feb 1, 2021

Hi @bdenham, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@bdenham bdenham deleted the patches-1.0.9 branch February 1, 2021 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.4.x Magento 2.4.x related changes Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content Progress: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants