Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Fixed view model name on Layout XML file #8505

Closed
wants to merge 2 commits into from
Closed

Fixed view model name on Layout XML file #8505

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 12, 2021

Purpose of this pull request

This pull request (PR) correction the model view name, the name must be separated by an underscore

Affected DevDocs pages

Links to Magento source code

  • ...

https://magento.stackexchange.com/questions/227479/block-getviewmodel-returning-null/318026#318026

@ghost ghost changed the title Update view-models.md Fixed view model name on Layout XML file Jan 12, 2021
@hostep
Copy link
Contributor

hostep commented Jan 12, 2021

Thanks @DeoJr, but it looks like there are already at least 2 competing PR's around this topic:

@dobooth
Copy link
Contributor

dobooth commented Jan 13, 2021

Thanks for pointing that out, @hostep. I think it's proper to take the first PR that fixed it, so we will go with #8459 and close these other two. But I still would like a technical review check on #8459 from someone. And thanks to @pawan and @DeoJr for submitting PRs around this.

@dobooth dobooth closed this Jan 13, 2021
@ghost
Copy link

ghost commented Jan 13, 2021

Hi @DeoJr, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Partner: Webjump partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants