Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

MCLOUD-7120: Add command which validate .magento.env.yaml locally before push #8486

Merged
merged 6 commits into from
Jan 8, 2021
Merged

Conversation

oshmyheliuk
Copy link
Contributor

Purpose of this pull request

This pull request (PR) will add information about a new command in ece-tools

Affected DevDocs pages

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change but also for some reason it is asking for the Adobe CLA to be signed! @dobooth can you advise why this is happening?

Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
@oshmyheliuk
Copy link
Contributor Author

@BarnyShergold looks like I needed to sign Adobe CLA

@hguthrie hguthrie added the Internal Dev Differentiates work between community and Magento staff label Jan 7, 2021
Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just providing a preliminary review. @bdenham can handle the release note and final review when he returns.

@oshmyheliuk oshmyheliuk requested a review from hguthrie January 8, 2021 14:43
Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! I made a small suggestion that keeps consistency in the Cloud guide for sample responses, but other than that it really help to see samples. Thanks for adding!

@hguthrie hguthrie merged commit 826644f into magento:ece-tools-2002.1.5 Jan 8, 2021
@ghost
Copy link

ghost commented Jan 8, 2021

Hi @oshmyheliuk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mmansoor-magento mmansoor-magento deleted the MCLOUD-7120 branch August 3, 2023 08:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Internal Dev Differentiates work between community and Magento staff Progress: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants