-
Notifications
You must be signed in to change notification settings - Fork 1.7k
MCLOUD-7120: Add command which validate .magento.env.yaml locally before push #8486
MCLOUD-7120: Add command which validate .magento.env.yaml locally before push #8486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change but also for some reason it is asking for the Adobe CLA to be signed! @dobooth can you advise why this is happening?
Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
@BarnyShergold looks like I needed to sign Adobe CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just providing a preliminary review. @bdenham can handle the release note and final review when he returns.
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! I made a small suggestion that keeps consistency in the Cloud guide for sample responses, but other than that it really help to see samples. Thanks for adding!
Hi @oshmyheliuk, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) will add information about a new command in
ece-tools
Affected DevDocs pages