Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

#8458 getViewModel() results in null #8459

Merged
merged 2 commits into from
Jan 22, 2021
Merged

#8458 getViewModel() results in null #8459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eb4a55
change viewModel name in xml references to view_model and update rela…
chrisfwd Dec 31, 2020
11ab575
Merge branch '2.4.2-develop' into bugfix/#8458-getviewmodel-results-i…
dobooth Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/guides/v2.3/extension-dev-guide/view-models.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ View models can be used by passing the view model class as an argument to a temp
```xml
<block name="orangeco.new.viewmodel" template="OrangeCompany_Catalog::example.phtml">
<arguments>
<argument name="viewModel" xsi:type="object">OrangeCompany\Catalog\ViewModel\MyNewViewModel</argument>
<argument name="view_model" xsi:type="object">OrangeCompany\Catalog\ViewModel\MyNewViewModel</argument>
</arguments>
</block>
```
Expand All @@ -34,7 +34,7 @@ In the following example, the same view model is used with an existing block in
```xml
<referenceBlock name="checkout.cart.item.renderers.default">
<arguments>
<argument name="viewModel" xsi:type="object">OrangeCompany\Catalog\ViewModel\MyNewViewModel</argument>
<argument name="view_model" xsi:type="object">OrangeCompany\Catalog\ViewModel\MyNewViewModel</argument>
</arguments>
</referenceBlock>
```
Expand Down Expand Up @@ -78,7 +78,7 @@ The view model class is passed as an argument to the `product.info.upsell` block
<block class="Magento\Catalog\Block\Product\ProductList\Upsell" name="product.info.upsell" template="Magento_Catalog::product/list/items.phtml">
<arguments>
<argument name="type" xsi:type="string">upsell</argument>
<argument name="viewModel" xsi:type="object">Magento\Catalog\ViewModel\Product\Listing\PreparePostData</argument>
<argument name="view_model" xsi:type="object">Magento\Catalog\ViewModel\Product\Listing\PreparePostData</argument>
</arguments>
</block>
```
Expand Down
4 changes: 2 additions & 2 deletions src/guides/v2.3/frontend-dev-guide/layouts/xml-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ There are examples of all argument types.
- The *object* type:

```xml
<argument name="viewModel" xsi:type="object">Vendor\CustomModule\ViewModel\Class</argument>
<argument name="view_model" xsi:type="object">Vendor\CustomModule\ViewModel\Class</argument>
```

The `Vendor\CustomModule\ViewModel\Class` class should implement the `\Magento\Framework\View\Element\Block\ArgumentInterface` interface.
Expand Down Expand Up @@ -394,7 +394,7 @@ $someString = $block->getData('some_string'); //or $block->getSomeString()
$isActive = $block->getData('is_active'); //or $block->getIsActive()

/** @var Vendor\CustomModule\ViewModel\Class|\Magento\Framework\View\Element\Block\ArgumentInterface $viewModel */
$viewModel = $block->getData('viewModel'); //or $block->getViewModel()
$viewModel = $block->getData('view_model'); //or $block->getViewModel()

/** @var string|int|float $someNumber */
$someNumber = $block->getData('some_number'); //or $block->getSomeNumber()
Expand Down
4 changes: 2 additions & 2 deletions src/guides/v2.3/frontend-dev-guide/layouts/xml-manage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ Let us say that we want to add functionality to a core template with custom logi
<body>
<referenceBlock name="checkout.cart.item.renderers.default">
<arguments>
<argument name="viewModel" xsi:type="object">Vendor\CustomModule\ViewModel\Class</argument>
<argument name="view_model" xsi:type="object">Vendor\CustomModule\ViewModel\Class</argument>
</arguments>
</referenceBlock>
</body>
Expand Down Expand Up @@ -539,7 +539,7 @@ Then, in the `cart/item/default.phtml` file, use the viewModel:

```php
/** @var \Vendor\CustomModule\ViewModel\Class $viewModel */
$viewModel = $block->getData('viewModel');
$viewModel = $block->getViewModel();

$viewModel->canShowAdditionalData();
```
Expand Down