-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update PHP settings on performance best practices software page #8396
Update PHP settings on performance best practices software page #8396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the second reviewer double-check the technical truthfulness of this addition? I'm not aware that this setting has anything to do with updating env.php
Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hguthrie - Could do with a second opinion on the technical accuracy of this change. 'm not aware of a PHP setting having this effect
It may seem that adding this note will help, but after some research, I found that the next release of Cloud tools addresses this with a less manual approach. See #8240 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not be necessary. Waiting for feedback related to release notes.
Sorry I'm late to the party. Looking at this now and finding a second opinion about the accuracy. It is more useful than the release note because of the details it provides. |
I talked to @meker12 about this and as she said: " For Magento on-premise, the default for Margaret also mentioned a support article for the issue: https://support.magento.com/hc/en-us/articles/360050422532 I'm still waiting to hear back from a Cloud developer, but at a minimum, it looks like this needs to be added to the Cloud Guide, not Performance Best Practices. |
@hguthrie mentioned the 2.1.4 ECE tools improvement that sets the |
@dobooth This has a support article that provides this information in further detail. The next release of Cloud tools contains corrections or additional information for this issue. If we add this note now, it has to be cleaned or updated for the Cloud release. @bdenham stated he is waiting for Cloud team feedback, so I will mark this PR as waiting. If @bdenham decides to proceed with this PR, then this change must be reviewed again during the Cloud docs release so that it agrees with the changes made by the Cloud team. |
Yeah, I'm going to close this for all the reasons mentioned above. The setting is now set correctly by default, so it would create more confusion if this was added. Regardless, thanks @chiranjeevi-cj for your heads-up work on this. |
Hi @chiranjeevi-cj, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) Updates PHP settings on the performance best practices software page
Affected DevDocs pages
Fixes #8394