Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Issue 8189 - L2 caching example change #8194

Merged
merged 2 commits into from
Nov 24, 2020

Conversation

dineshvb
Copy link
Contributor

@dineshvb dineshvb commented Nov 6, 2020

Purpose of this pull request

This pull request (PR) will cover #8189

Affected DevDocs pages

  • guides/v2.4/config-guide/cache/two-level-cache.html

@@ -21,28 +21,30 @@ Magento stores the hashed data version in Redis, with the suffix ':version' appe
```php
'cache' => [
[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may still have an error here. The cache node should not contain another array. Please, correct me if I'm wrong

Suggested change
[

@rogyar rogyar added the Technical Updates to the code or processes that alter the technical content of the doc label Nov 8, 2020
@dineshvb
Copy link
Contributor Author

dineshvb commented Nov 9, 2020

@rogyar Would need some technical assistance so that I could change it.

@rogyar
Copy link
Contributor

rogyar commented Nov 10, 2020

Hi @dineshvb. Could you clarify, please, what type of technical assistance do you need? Thanks.

@dineshvb
Copy link
Contributor Author

@rogyar just that array symbol, shall I delete it?

@rogyar
Copy link
Contributor

rogyar commented Nov 12, 2020

Hi @dineshvb. Here is the correct version of your example

'cache' => [
    'frontend' => [
        'default' => [
            'backend' => '\\Magento\\Framework\\Cache\\Backend\\RemoteSynchronizedCache',
            'backend_options' => [
                'remote_backend' => '\\Magento\\Framework\\Cache\\Backend\\Redis',
                'remote_backend_options' => [
                    'persistent' => 0,
                    'server' => 'localhost',
                    'database' => '0',
                    'port' => '6370',
                    'password' => '',
                    'compress_data' => '1',
                ],
                'local_backend' => 'Cm_Cache_Backend_File',
                'local_backend_options' => [
                    'cache_dir' => '/dev/shm/'
                ]
            ],
            'frontend_options' => [
                'write_control' => false,
            ],
            'use_stale_cache' => false,
        ]
    ],
    'type' => [
        'default' => ['frontend' => 'default'],
    ]
]

@dineshvb dineshvb requested a review from rogyar November 17, 2020 05:57
@dineshvb
Copy link
Contributor Author

@rogyar @dobooth I have made the requested changes

@dobooth
Copy link
Contributor

dobooth commented Nov 19, 2020

Is this another change for master?

@dineshvb
Copy link
Contributor Author

Is this another change for master?

No, these changes are for 2.4.2-develop branch since the issue only addresses the 2.4 version

@dobooth
Copy link
Contributor

dobooth commented Nov 23, 2020

Thanks @dineshvb. To be clear, the master branch is for currently release docs, v2.3 and v2.4, which includes 2.4.1. If this is a fix to a live doc, then it would go to master. The 2.4.2-develop branch is to document code for features that will be available in the 2.4.2 release, which is early next year. If we keep this as it is, it will not go live until the release next year.

@dineshvb dineshvb force-pushed the issue-8189-l2-caching-example-change branch from b7eb73a to a854e8d Compare November 24, 2020 06:22
@dineshvb dineshvb changed the base branch from 2.4.2-develop to master November 24, 2020 06:23
@dineshvb
Copy link
Contributor Author

@dobooth Rebased to master branch

@dobooth dobooth added the 2.4.x Magento 2.4.x related changes label Nov 24, 2020
@dobooth
Copy link
Contributor

dobooth commented Nov 24, 2020

running tests

@dobooth dobooth merged commit f2d3d9b into magento:master Nov 24, 2020
@ghost
Copy link

ghost commented Nov 24, 2020

Hi @dineshvb, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.4.x Magento 2.4.x related changes Partner: Zilker Technology partners-contribution PR created by Magento partner Progress: approved Progress: done Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants