This repository was archived by the owner on Nov 19, 2024. It is now read-only.
pass "entity_type_code" instead of "entity_type_id" #8184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frontend code should not have to rely on knowing the `eav_entity_type.entity_type_id` value of the model it is querying attribute information on. Local tests show that this field also supports `eav_entity_type.entity_type_code` values as well.
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
rogyar
added
2.3.x
|
Can confirm that the entity type code should be passed instead of ID. An example of the test from the codebase is below |
rogyar
approved these changes
Nov 5, 2020
dobooth
approved these changes
Nov 6, 2020
dobooth
added
the
Technical
|
Hi @dfelton, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Frontend code should not have to rely on knowing the
eav_entity_type.entity_type_idvalue of the model it is querying attribute information on. Local tests show that this field also supportseav_entity_type.entity_type_codevalues as well.Affected DevDocs pages