Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Updated another way of string translation in js #8098

Merged
merged 7 commits into from
Nov 6, 2020

Conversation

srsathish92
Copy link
Contributor

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srsathish92
Copy link
Contributor Author

@BarnyShergold Thank you for review

@hguthrie hguthrie added the Technical Updates to the code or processes that alter the technical content of the doc label Oct 27, 2020
@dobooth
Copy link
Contributor

dobooth commented Nov 6, 2020

running tests

@dobooth dobooth merged commit d0b7755 into magento:master Nov 6, 2020
@ghost
Copy link

ghost commented Nov 6, 2020

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hacktoberfest-accepted Partner: Ziffity partners-contribution PR created by Magento partner Progress: done Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants