Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Adds information about securing the Swagger endpoint #8064

Merged
merged 9 commits into from
Oct 16, 2020
Merged

Conversation

dobooth
Copy link
Contributor

@dobooth dobooth commented Oct 15, 2020

Purpose of this pull request

This pull request (PR) adds info about disabling /swagger or using mod_rewrite

Fixes #1996

Affected DevDocs pages

https://devdocs.magento.com/guides/v2.4/rest/generate-local.html
https://devdocs.magento.com/guides/v2.3/rest/generate-local.html

whatsnew
Added a Security section to the Generate a local REST reference topic.

@dobooth dobooth added Major Update Significant original updates to existing content 2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes labels Oct 15, 2020
@dobooth dobooth self-assigned this Oct 15, 2020
Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition!
You also have some Linting errors that need to be fixed

dobooth and others added 2 commits October 16, 2020 08:52
Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
@dobooth
Copy link
Contributor Author

dobooth commented Oct 16, 2020

running tests

@dobooth dobooth merged commit 165ac94 into master Oct 16, 2020
@ghost
Copy link

ghost commented Oct 16, 2020

Hi @dobooth, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth deleted the db_swagger_docs branch October 16, 2020 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate Local Swagger Documentation Security Note Missing
3 participants