Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

update using-font for 2.4.2. New parameter font-type for custom fonts #8026

Merged
merged 4 commits into from
Oct 14, 2020

Conversation

PierW
Copy link
Member

@PierW PierW commented Oct 12, 2020

Purpose of this pull request

With the version 2.4.2 of Magento, there will be the new parameter for the font-type: <font_type> for the mixin .lib-font-face(). (See issue #30288 on Magento2 repo)
This update describes it.

Affected DevDocs pages

Resolved issues:

  1. resolves [Issue] update using-font for 2.4.2. New parameter font-type for custom fonts #8027: update using-font for 2.4.2. New parameter font-type for custom fonts

@PierW
Copy link
Member Author

PierW commented Oct 12, 2020

@magento create issue

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good now!

@mrtuvn
Copy link
Contributor

mrtuvn commented Oct 12, 2020

@PierW @font-type: 'truetype seem you missing this one quote at line 50

@BarnyShergold
Copy link
Contributor

@PierW @font-type: 'truetype seem you missing this one quote at line 50

Blimey - Eagle eyes - well spotted! I'd read that twice and didn't see that!

@PierW
Copy link
Member Author

PierW commented Oct 13, 2020

@PierW @font-type: 'truetype seem you missing this one quote at line 50

@mrtuvn Eagle eyes, I fixed it, thanks!
@BarnyShergold

@dobooth
Copy link
Contributor

dobooth commented Oct 14, 2020

running tests

@dobooth dobooth merged commit 0ad0bf3 into magento:2.4.2-develop Oct 14, 2020
@ghost
Copy link

ghost commented Oct 14, 2020

Hi @PierW, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants