Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

magento/devdocs#7029: for text column in db_schema the attribute 'length' is not allowed. #7045

Merged
merged 2 commits into from
Apr 16, 2020
Merged

magento/devdocs#7029: for text column in db_schema the attribute 'length' is not allowed. #7045

merged 2 commits into from
Apr 16, 2020

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Apr 16, 2020 •
edited by jcalcaben
Loading

Purpose of this pull request

This pull request (PR) fixes #7029.

Affected DevDocs pages

Links to Magento source code

  • TEXT MySQL string data type

Thank you!

whatsnew
Added correct db schema information in the Configure declarative schema topic

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@atwixfirster atwixfirster mentioned this pull request Apr 16, 2020
Closed
@rogyar rogyar self-assigned this Apr 16, 2020
@rogyar
Copy link
Contributor

rogyar commented Apr 16, 2020

An example from the codebase

https://github.com/magento/magento2/blob/5f3b86ab4bd3e3b94e65429fed33f748d29c1bbe/app/code/Magento/Newsletter/etc/db_schema.xml#L44

@rogyar rogyar added the 2.3.x Magento 2.3 related changes label Apr 16, 2020
@dobooth dobooth added the Technical Updates to the code or processes that alter the technical content of the doc label Apr 16, 2020
@dobooth
Copy link
Contributor

dobooth commented Apr 16, 2020

running tests

@dobooth dobooth merged commit 393eb33 into magento:master Apr 16, 2020
@ghost
Copy link

ghost commented Apr 16, 2020

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@milindsingh
Copy link
Member

@atwixfirster I think this can also be updated.

Configure declarative schema Magento 2 Developer Documentation

@atwixfirster
Copy link
Contributor Author

@atwixfirster I think this can also be updated.

@milindsingh , done in #7057

Thanks for notice!

@jcalcaben jcalcaben added Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies and removed Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies labels Apr 21, 2020
@lano-vargas
Copy link

Also in the docs you may want to update it has an example with type text which contains length ref: https://developer.adobe.com/commerce/php/development/components/declarative-schema/configuration/#add-an-index

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

Labels
2.3.x Magento 2.3 related changes Partner: Atwix partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

for text column in db_schema the attribute 'length' is not allowed.
8 participants
@atwixfirster @devops-devdocs @rogyar @dobooth @milindsingh @lano-vargas @jcalcaben @magento-engcom-team