This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Added 'Strings added in Underscore templates' section to 'Translate theme strings' page #6926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Atwix
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
rogyar
suggested changes
Mar 25, 2020
| <%= _.i18n('Hello') %> | ||
| ``` | ||
|
|
||
| - When a string contains a variable, to add a placeholder for this variable to the string stored in the dictionary, use the syntax similar to the following: |
There was a problem hiding this comment.
Please, simplify this statement
Suggested change
| - When a string contains a variable, to add a placeholder for this variable to the string stored in the dictionary, use the syntax similar to the following: | |
| - When the string contains a variable, use the variable placeholder for processing string stored in the dictionary: |
There was a problem hiding this comment.
Thank you for suggestion, the changes has been added.
rogyar
added
2.4.x
…te theme strings' page
sergiy-v
force-pushed
the
translate-theory-add-strings-underscore-html
branch
from
97d9acf to
6a1715e
Compare
rogyar
approved these changes
Mar 26, 2020
dobooth
approved these changes
Mar 26, 2020
|
running tests |
|
Hi @sergiy-v, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds the 'Strings added in Underscore templates' section to the 'Translate theme strings' page according to the following PR.
Affected DevDocs pages
https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/translations/translate_theory.html
Links to Magento source code
https://github.com/magento/magento2/blob/2.4-develop/lib/web/mage/translate.js#L50
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Translation/etc/di.xml#L67