Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Update docs about composer-packaged themes to include naming convention #4777

Merged
merged 2 commits into from
Jun 21, 2019

Conversation

DrewML
Copy link
Contributor

@DrewML DrewML commented Jun 18, 2019

@DrewML DrewML force-pushed the theme-composer-name branch from 492e105 to 117c0f8 Compare June 18, 2019 15:16
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@jeff-matthews jeff-matthews self-assigned this Jun 19, 2019
@jeff-matthews jeff-matthews added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc labels Jun 19, 2019
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DrewML! Just add the periods as suggested and I'll merge this.

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
@DrewML
Copy link
Contributor Author

DrewML commented Jun 19, 2019

Done - thanks for making it easy!

@jeff-matthews
Copy link
Contributor

Thanks for updating the docs!

@jeff-matthews jeff-matthews changed the base branch from master to small_changes June 21, 2019 13:24
@jeff-matthews jeff-matthews merged commit a3b1d72 into magento:small_changes Jun 21, 2019
@ghost
Copy link

ghost commented Jun 21, 2019

Hi @DrewML, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@jeff-matthews jeff-matthews mentioned this pull request Jun 21, 2019
@dobooth dobooth mentioned this pull request Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants