Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Update checkout_new_step.md #4399

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Update checkout_new_step.md #4399

merged 2 commits into from
Jun 17, 2019

Conversation

jaykobi
Copy link

@jaykobi jaykobi commented May 2, 2019 •
edited by dobooth
Loading

Custom step is hidden when using back button

Purpose of this pull request

Updates javascript example to include the custom step in browser history.

Update checkout_new_step.md
c94c2c9 
Custom step is hidden when using back button
@magento-engcom-team
Copy link

@skymeissner thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@osrecio osrecio self-assigned this May 3, 2019
@osrecio
Copy link
Member

osrecio commented May 3, 2019

Hi @skymeissner , Can you update your PR adding information required. Please¿?

  • Purpose of PR
  • Link Affected in devdocs.magento.com
  • Links to codebase if needed

@dobooth dobooth added the Waiting for Response Waiting for response from internal/external parties label May 9, 2019
@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dobooth
❌ jakobmeissner

@dobooth dobooth added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc and removed Waiting for Response Waiting for response from internal/external parties labels Jun 17, 2019
@dobooth dobooth changed the base branch from master to small_changes June 17, 2019 21:33
@dobooth
Copy link
Contributor

dobooth commented Jun 17, 2019

Researched this and the answer is correct.

@dobooth dobooth merged commit 83db90a into magento:small_changes Jun 17, 2019
@ghost
Copy link

ghost commented Jun 17, 2019

Hi @jakobmeissner, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@jeff-matthews jeff-matthews mentioned this pull request Jun 21, 2019
Merged
@dobooth dobooth mentioned this pull request Jun 28, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dobooth dobooth dobooth approved these changes

Assignees

@osrecio osrecio

Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jaykobi @magento-engcom-team @devops-devdocs @osrecio @magento-cicd2 @dobooth