Skip to content

feature request: make _calcHeight and _isOverflowed of minicart sidebar.js optional #83

@magento-engcom-team

Description

@magento-engcom-team

Preconditions

  1. add more than 6 items to the cart
  2. open the minicart
  3. all current Magento versions (2.2.4+, 2.3, 2.1.x)

Steps to reproduce

  1. open the minicart
  2. the

Expected result

  1. an option to disable both methods to prevent the calculated height / scroll

Actual result

  1. I can not disable these options without overwriting sidebar.js

I think it also makes sense to optionally support some maxHeight value instead of maxItems value as some items have many lines of text in the name in some shops (long product names which include product attributes) so 65 items for example could also take much height. When we make both optionally we can use CSS values however we want to.

Original Report: magento/magento2#17433 by @DanielRuf

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions