Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP requirement not documented #44

Closed
theCapypara opened this issue Feb 3, 2020 · 2 comments
Closed

PHP requirement not documented #44

theCapypara opened this issue Feb 3, 2020 · 2 comments
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@theCapypara
Copy link
Member

It seems that baler needs a PHP executable. This is not documented. Of course if you work with Magento you usually also have PHP installed, but I was building a Docker image for baler and didn't realize that PHP was also directly required for executing baler.

It would be great, if the documentation included that information.

Also why does baler need a PHP executable...?

theCapypara added a commit to theCapypara/magento-baler-docker that referenced this issue Feb 3, 2020
@DrewML
Copy link
Contributor

DrewML commented Feb 3, 2020

Thanks for the report, @Parakoopa.

Happy to accept a PR for a docs update.

Also why does baler need a PHP executable...?

/**
* @summary Invokes the PHP binary and extracts info about modules
* and themes from a store
*/

@DrewML DrewML added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Feb 6, 2020
@DrewML
Copy link
Contributor

DrewML commented Feb 6, 2020

Looks like I used to have this documented and then lost it - whoops!

6. Verify you either have `php` available in your `$PATH`, or set the `$BALER_PHP_PATH` environment variable to point to the binary

theCapypara added a commit to theCapypara/baler that referenced this issue Feb 6, 2020
@DrewML DrewML closed this as completed in a89a97f Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants